Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

Replace vertex lru cache with rocksdb row cache #532

Merged
merged 5 commits into from
Jul 28, 2021
Merged

Replace vertex lru cache with rocksdb row cache #532

merged 5 commits into from
Jul 28, 2021

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Jul 22, 2021 •
edited
Loading

  1. Replace vertex LRU cache with rocksdb row cache, to avoid annoying inconsistency
  2. Since no mvcc any more, replace some prefix with get, just like Try to use whole key bloom filter when insert data with index nebula#2377 in 1.0

Close #530.

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Jul 22, 2021
bright-starry-sky
bright-starry-sky reviewed Jul 23, 2021
View reviewed changes
src/storage/exec/EdgeNode.h
}

void next() override {
valid_ = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Contributor Author

@critical27 critical27 Jul 23, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are for fetch vertex/edge, only first data should be used. Previously this job is handled in StorageIterator, when we change from prefix to get, there is no more rocksdb iterator.

cangfengzhs
cangfengzhs approved these changes Jul 27, 2021
View reviewed changes
Copy link

@cangfengzhs cangfengzhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bright-starry-sky
bright-starry-sky approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bright-starry-sky bright-starry-sky merged commit 0b54cac into vesoft-inc:master Jul 28, 2021
@critical27 critical27 deleted the cache branch July 28, 2021 03:33
@jamieliu1023 jamieliu1023 mentioned this pull request Jul 31, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@cangfengzhs cangfengzhs cangfengzhs approved these changes

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@linkensphere201 linkensphere201 Awaiting requested review from linkensphere201

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

@panda-sheep panda-sheep Awaiting requested review from panda-sheep

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VertexCache will destroy the consistency of raft
3 participants
@critical27 @cangfengzhs @bright-starry-sky